Skip to content

Bump nginx from 1.29.8 to 1.31.1#84

Merged
alarthast merged 1 commit into
mainfrom
dependabot/docker/nginx-1.31.1
May 28, 2026
Merged

Bump nginx from 1.29.8 to 1.31.1#84
alarthast merged 1 commit into
mainfrom
dependabot/docker/nginx-1.31.1

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github May 25, 2026

Bumps nginx from 1.29.8 to 1.31.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps nginx from 1.29.8 to 1.31.1.

---
updated-dependencies:
- dependency-name: nginx
  dependency-version: 1.31.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file docker Pull requests that update docker code labels May 25, 2026
Copy link
Copy Markdown
Contributor

@alarthast alarthast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the changes doc:

*) Change: now nginx rejects HTTP/2 and HTTP/3 requests with the
   "Connection", "Proxy-Connection", "Keep-Alive", "Transfer-Encoding",
   "Upgrade" header lines, and "TE" with any value other than
   "trailers".

I think I understand and agree with Claude's interpretation:

If you have any clients that were sending these headers over HTTP/2 or HTTP/3, they'll start getting errors after upgrading nginx. The fix is on the client side — they shouldn't be sending those headers at all.

but I'm not sure how relevant it is to us. If it is only our services that are using the proxy and they end up hitting this error, then would it be straightforward to update the headers used by those services?

@rebkwok
Copy link
Copy Markdown
Contributor

rebkwok commented May 28, 2026

tl;dr I think it's fine

The headers are all HTTP/1.1-specific and are irrelevant to HTTP/2 and HTTP/3; nginx used to ignore them and now it's going to error instead. Services that call the proxy are airlock, jobrunner and the otel collector. Airlock and job-runner use requests, which only uses HTTP/1.1; so although we do send keep-alive headers at least (both use module-level Session objects), they won't be affected. The otel collector is using an otel-gateway endpoint for the otlp_http exporter which goes via the proxy; the exporter can use HTTP/2 if it's going via HTTPS (which it is), but it doesn't set any of the problematic headers.

(N.B. I also asked Claude and google for most of that 😄 )

@alarthast
Copy link
Copy Markdown
Contributor

Thanks very much Becky! 😄 I think that would have took me really long to figure out.
I'll merge this then 👍

@alarthast alarthast enabled auto-merge May 28, 2026 11:06
@alarthast alarthast merged commit 9b8b741 into main May 28, 2026
2 checks passed
@alarthast alarthast deleted the dependabot/docker/nginx-1.31.1 branch May 28, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file docker Pull requests that update docker code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants