Repository navigation
fix(check): ask the live season for the task set when miner.yaml does not say (1.5.1) - #17
Merged
Merged
Conversation
… not say (1.5.1) A miner ran check from the CLI repo, with no workspace config, so the task set was unknown and the LIBERO default flagged his correct AXIS checkpoint again. When the snapshot has no benchmark, check now reads the live season once and judges by its task set; unreachable or ambiguous keeps LIBERO and says so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kyleab upgraded to 1.5.0 and ran
openroboto checkfrom the CLI repo, with no workspaceminer.yaml: the task set was unknown,checkfell back to the LIBERO layout and flagged his correct AXIS checkpoint again (submitwas fine — it reads the live season).checknow asks/api/v1/competitionsonce when the snapshot has nobenchmark: the season the snapshot names, else the only π0.5 sim season. Unreachable or ambiguous → LIBERO layout, with a note. Tests never touch the network (fetch stubbed); new tests for the live lookup and the ambiguous case; removing the lookup turns one red. 456 passed, lint green. 1.5.1 + CHANGELOG.