tests: fix the PR title check broken by the action bump to v6.1.1 - #410
Merged
Merged
Conversation
Since v6.1.0 each line of the `types` input is treated as a regex pattern auto-wrapped in `^ $` (amannn/action-semantic-pull-request#292), so the trailing "# comment" became part of the pattern: the line "bugfix # bug fixes" means regex ^bugfix # bug fixes$, which can never match the type token in a PR title. Every PR has failed the "Lint PR" check since the bump in db281a3. Under @v4 the input was split on whitespace into plain strings, so "bugfix # bug fixes" accidentally yielded the bare token "bugfix", which matched. That accidental tolerance is gone in v6. Fix: list each type as one bare line on the strip block scalar (`|-`), as the v6 docs describe and as other repos pinning the same v6.1.1 SHA do: https://github.com/projen/projen/blob/main/.github/workflows/pull-request-lint.yml#L23-L30
tzssangglass
force-pushed
the
fix-pr-title-check
branch
from
September 6, 2026 14:30
75a0644 to
fa0132b
Compare
zhuizhuhaomeng
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v6.1.0 each line of the
typesinput is treated as a regex pattern auto-wrapped in^ $(amannn/action-semantic-pull-request#292), so the trailing "# comment" became part of the pattern: the line "bugfix # bug fixes" means regex ^bugfix # bug fixes$, which can never match the type token in a PR title. Every PR has failed the "Lint PR" check since the bump in db281a3.Under
@v4the input was split on whitespace into plain strings, so "bugfix # bug fixes" accidentally yielded the bare token "bugfix", which matched. That accidental tolerance is gone in v6.Fix: list each type as one bare line, as the v6 docs describe and as other repos pinning the same v6.1.1 SHA do:
https://github.com/projen/projen/blob/main/.github/workflows/pull-request-lint.yml#L23-L30