PPC64: use pointer-width accesses when resetting string buffer - #276
Open
mchoo7 wants to merge 1 commit into
Open
PPC64: use pointer-width accesses when resetting string buffer#276mchoo7 wants to merge 1 commit into
mchoo7 wants to merge 1 commit into
Conversation
The PPC string lower/upper/reverse fast-function wrapper resets SBuf::w from SBuf::b using lwz/stw. Both fields are char pointers, so these 32-bit accesses are incorrect on PPC64. This breaks the reset on big-endian PPC64, causing string.lower(), string.upper(), and string.reverse() to append to stale temporary buffer contents. Use lp/stp so the accesses have the target pointer width.
Contributor
|
Found one blocking issue relative to
Confirmed in an isolated native build with the PPC64 C path enabled:
Can you check the review by AI @mchoo7 |
Author
This PR does not touch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PPC string lower/upper/reverse fast-function wrapper resets SBuf::w from SBuf::b using lwz/stw. Both fields are char pointers, so these 32-bit accesses are incorrect on PPC64.
This breaks the reset on big-endian PPC64, causing string.lower(), string.upper(), and string.reverse() to append to stale temporary buffer contents.
Use lp/stp so the accesses have the target pointer width.