[ebariaux]

Description

Fixes #3478. Part of #2675.

AssetsFacade.getResults modified caller-owned queries when applying engine scope and storage defaults. Reusing an asset-scoped query through a realm or global engine could retain the earlier asset-path restriction. Each execution now uses an independent AssetQuery copy, preserving the caller's filters and preventing later caller edits from changing an earlier execution's query.

Add a copy constructor and copying support for nested logical groups, attribute predicates, metadata, paths and mutable values. Preserve null versus empty selections, numeric precision and predicate types. Built-in value predicates are copied explicitly; custom serializable predicates use Java serialization. The facade applies its projection to the copy, so it no longer needs to restore the caller's projection afterwards.

Regression tests cover query reuse across global, realm and asset engines, storage-added defaults, nested mutation isolation, empty selections and predicate copying. Enable manager/src/test/groovy alongside the existing test directory. Path-filter preservation remains tracked separately in #3479.

Validation: ./gradlew --offline --no-daemon :model:test :manager:test — all 393 tests passed (57 model, 336 manager). Regression tests were added and confirmed failing before the fix.

Checklist

• 1. Acceptance criteria of the linked issue(s) are met
• 2. Tests are written and all tests pass (model and manager unit suites)
• 3. Changes are manually tested by you and the reviewer
• 4. Documentation is written or updated (copying behavior documented in code)

[wborn]

This is an initial AI-assisted review.

The query isolation fix looks good overall. The copy constructor preserves the caller's query options and nested predicates, and the regression tests cover reuse across different rule engine scopes.

One potential compatibility edge case is worth considering: copying an ArrayPredicate can reject JSON-serializable values that don't implement Serializable. This does not appear to affect existing usages in the repository.

No blocking issues were identified.

[wborn]

The updated implementation addresses the previously reported issue with non-Serializable array predicate payloads. The expanded regression tests also provide good coverage of query isolation, nested mutable values, and preservation of query options.

One remaining edge case is worth considering: Java serialization can silently discard JSON-visible transient state, potentially changing the database filter. This appears unlikely to affect existing usages, so it is not considered blocking.

No further blocking issues were identified.

This review was AI-assisted.

[sonarqubecloud]

Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud