Repository navigation
Reject ignored execution flags on account commands in Rust - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust account/package commands silently ignored execution-only runner globals, while Bun rejected them. An agent could supply
--harness,--cwdor--timeoutand receive success even though the control had no effect.Reject execution-only globals before credential access, preserving the existing service-operation error envelope, exit 2 and rendering options. Shared controls cover 18 denied prefixes across five commands and three rendering positives. Malformed fixture data proves rejection precedes credential parsing. Bun already implements this boundary.
Validation: unchanged Rust fails the regression; corrected Rust passes all 93 controls. Bun passes 549 assertions. Independent exact-head review and replay found no findings. Full CI caught two strict Rust lint issues; the follow-up extracts account routing and fixes a needless test borrow. Strict CLI Clippy and the regression now pass. Final full CI passes all 15 checks. The baseline, failed CI and review evidence are retained in workspace IMP-089.
No new Python, model call, credential mutation, release or deployment.
Final head f9f57ce passes all 15 checks. Both source-admission platforms executed the shared Rust and Bun credential-boundary controls. Full logs and check identities are retained in IMP-089.