fix(background-terminals): avoid false success after Windows taskkill timeout - #412
Merged
tt-a1i merged 2 commits intoSep 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #408. On Windows, a slow
taskkill /T /Fhelper can exceed its bounded wait, get force-closed, and then fall back tochild.kill(). That only terminates the shell and can orphan descendants while the manager reports successful termination.Value
A timed-out tree kill is reported as unresolved instead of claiming that the full process tree was terminated. This keeps background-terminal state truthful and avoids silently leaving servers or descendants holding resources.
Approach
Treat every Windows
taskkilltimeout as unresolved, including the case where the helper closes after SIGKILL. Keep the existing time bounds, direct fallback behavior for non-timeout cases, and POSIX behavior unchanged. Cover both graceful and force timeouts, with the shell still alive or exiting during timeout. Every case stays unresolved and avoids a direct shell signal.Validation
bun run check— passed.bun run testata2c23a1— 1427 passed, 1 skipped; Vitest 30 passed.tests/extensions/subagents/manager.test.ts; its isolated rerun and a second complete suite passed.Impact