Skip to content

fix build issues with @opentelemetry#302

Merged
vicb merged 1 commit into
mainfrom
otel-fix
Jan 30, 2025
Merged

fix build issues with @opentelemetry#302
vicb merged 1 commit into
mainfrom
otel-fix

Conversation

@vicb

@vicb vicb commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

fixes #219
closes #259

@changeset-bot

changeset-bot Bot commented Jan 30, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 26402ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jan 30, 2025

Copy link
Copy Markdown

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@302

commit: 26402ee

Comment thread packages/cloudflare/src/cli/build/patches/plugins/require.ts
@vicb vicb requested a review from dario-piotrowicz January 30, 2025 14:26

@dario-piotrowicz dario-piotrowicz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😄

I'm sure I tried this sort of approach in the past (without using a plugin) without success, I'm guessing that maybe #282 made this work 🤔

either way it seems to work as intended 🥳

@vicb

vicb commented Jan 30, 2025

Copy link
Copy Markdown
Contributor Author

I'm sure I tried this sort of approach in the past (without using a plugin) without success, I'm guessing that maybe #282 made this work 🤔

Yep, it is probably linked to some of the patches inlining the code during the build instead of after...

either way it seems to work as intended 🥳

I have a test PR ready but it depends on the other pending test PR, I'll rebase upload after the other lands.
(Also one user reported that it fixes things)

Thanks for the review 🙏

@vicb vicb merged commit 67acb2f into main Jan 30, 2025
@vicb vicb deleted the otel-fix branch January 30, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][@opentelemetry] Could not resolve "../platform"

2 participants