Skip to content

misc minor refactoring#1239

Merged
vicb merged 1 commit intomainfrom
vicb/pr-1238
Apr 29, 2026
Merged

misc minor refactoring#1239
vicb merged 1 commit intomainfrom
vicb/pr-1238

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Apr 29, 2026

Supersedes #1238

@314systems I have extracted a few "safe" changes from your PR.

I guess some of the changes there might not be compatible with the minimum version of TS from package.json.
So it would take a long time to check every single change.

I also don't think there is a urge to change working code when there is no clear benefit / readability gain. We can change the code when we have to update it for other reason. We don't have unlimited resources to work on this project and allocating them to higher priority bug fixes / features is a better thing to do IMO.

Thanks!


Open in Devin Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 29, 2026

⚠️ No Changeset found

Latest commit: 57044d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 29, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@1239

commit: 57044d4

@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Apr 29, 2026

Thanks for the review James!

@vicb vicb merged commit b47b9b5 into main Apr 29, 2026
8 checks passed
@vicb vicb deleted the vicb/pr-1238 branch April 29, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants