Conversation
|
commit: |
james-elicx
approved these changes
Apr 29, 2026
Contributor
Author
|
Thanks for the review James! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1238
@314systems I have extracted a few "safe" changes from your PR.
I guess some of the changes there might not be compatible with the minimum version of TS from package.json.
So it would take a long time to check every single change.
I also don't think there is a urge to change working code when there is no clear benefit / readability gain. We can change the code when we have to update it for other reason. We don't have unlimited resources to work on this project and allocating them to higher priority bug fixes / features is a better thing to do IMO.
Thanks!