Skip to content

refactor: add explicit TypeScript return type annotations#1210

Open
314systems wants to merge 15 commits intoopennextjs:mainfrom
314systems:type
Open

refactor: add explicit TypeScript return type annotations#1210
314systems wants to merge 15 commits intoopennextjs:mainfrom
314systems:type

Conversation

@314systems
Copy link
Copy Markdown
Contributor

@314systems 314systems commented Apr 20, 2026

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 20, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4c7f00a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 20, 2026 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@1210

commit: 4c7f00a

vicb
vicb reviewed Apr 20, 2026
View reviewed changes
Comment thread packages/cloudflare/src/api/durable-objects/queue.ts Outdated
vicb
vicb reviewed Apr 20, 2026
View reviewed changes
Comment thread packages/cloudflare/src/api/overrides/incremental-cache/kv-incremental-cache.ts Outdated
vicb
vicb reviewed Apr 20, 2026
View reviewed changes
Comment thread packages/cloudflare/src/api/overrides/queue/memory-queue.ts Outdated
vicb
vicb reviewed Apr 20, 2026
View reviewed changes
Comment thread packages/cloudflare/src/api/overrides/queue/memory-queue.ts Outdated
vicb
vicb reviewed Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the added explicit return types.

I think some of the changes in this PR are not necessary (see my inline comments).

vicb
vicb reviewed Apr 20, 2026
View reviewed changes
Comment thread packages/cloudflare/src/api/durable-objects/queue.ts Outdated
vicb
vicb reviewed Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit

@314systems
revert unnecessary type annotations per review feedback
9ce60d3
@314systems
fix: include examples/common in pnpm workspace to resolve e2e test fa…
e6ce3ef 
…ilures

Removing the !examples/common exclusion fixes a TypeError where configurePlaywright
was not resolved as a function at runtime. Also set up proper TypeScript (strict
mode, @types/node) and add explicit return types to the package's exports.
@314systems
fix: add type annotation for rule parameter in computePatchDiff function
215c3a6
vicb
vicb reviewed Apr 21, 2026
View reviewed changes
Comment thread examples/common/config-e2e.ts Outdated
vicb
vicb reviewed Apr 21, 2026
View reviewed changes
Comment thread packages/cloudflare/src/cli/build/utils/test-patch.ts Outdated
vicb
vicb reviewed Apr 21, 2026
View reviewed changes
Comment thread packages/cloudflare/src/cli/build/patches/plugins/optional-deps.ts Outdated
@314systems 314systems requested a review from vicb April 24, 2026 09:26
@vicb
Copy link
Copy Markdown
Contributor

vicb commented Apr 24, 2026

@314systems I saw your review requests.

There are a few higher priority changes I'd like to get to before and I'll look into merging this after.

Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicb vicb Awaiting requested review from vicb

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@314systems @vicb