O3-5696: Fix Wrong ORM mapping, duplicate DB lookup & null crash#115
Open
UjjawalPrabhat wants to merge 1 commit into
Open
O3-5696: Fix Wrong ORM mapping, duplicate DB lookup & null crash#115UjjawalPrabhat wants to merge 1 commit into
UjjawalPrabhat wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Three independent backend defects in the queue module:
QueueEntry.queueComingFromused@OneToOne, implying each source queue belongs to a single entry. Many entries can transition from the same queue, so switch to@ManyToOne(matching queue/patient/visit/etc.).AbstractBaseQueueDaoImpl.get(uuid)executed its criteria query twice, discarding the first result. Drop the redundant call so each UUID lookup runs exactly one query (affects all queue DAOs via the base).QueueEntryResource.getDisplaynull-checkedpersonNamebut dereferenced a possibly-null patient first, throwing NPE on bad data rows and crashing the whole REST page. Null-check the patient and fall back to the queue entry UUID. Added a unit test for the null-patient case.