Skip to content

[MNT] Add assertions to run function tests #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aykay07 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MNT] Add assertions to run function tests #1736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions tests/test_runs/test_run_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,11 +342,11 @@ def _remove_random_state(flow):

# This is only a smoke check right now
# TODO add a few asserts here
run._to_xml()
assert isinstance(run._to_xml(), str)
if run.trace is not None:
# This is only a smoke check right now
# TODO add a few asserts here
run.trace.trace_to_arff()
trace_arff = run.trace.trace_to_arff()
assert trace_arff["relation"] == "Trace"
assert len(trace_arff["data"]) > 0

# check arff output
assert len(run.data_content) == num_instances
Expand Down Expand Up @@ -395,12 +395,8 @@ def _remove_random_state(flow):
downloaded = openml.runs.get_run(run_.run_id)
assert "openml-python" in downloaded.tags

# TODO make sure that these attributes are instantiated when
# downloading a run? Or make sure that the trace object is created when
# running a flow on a task (and not only the arff object is created,
# so that the two objects can actually be compared):
# downloaded_run_trace = downloaded._generate_trace_arff_dict()
# self.assertEqual(run_trace, downloaded_run_trace)
if run.trace is not None:
assert downloaded.trace is not None
return run

def _check_sample_evaluations(
Expand Down