Skip to content

fix: disable fingerprinting #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cb80 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: disable fingerprinting #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions internal/grpc/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,13 +137,6 @@ func (s *SessionServer) GetSession(ctx context.Context, req *sessionv1.GetSessio
return nil, dt.Err()
}

// Compare fingerprints
if sess.Fingerprint != req.GetFingerprint() {
span.SetStatus(codes.Ok, "fingerprint mismatch")
slogctx.Warn(ctx, "Is this an attack? Fingerprints do not match", "sessionFingerprint", sess.Fingerprint, "requestFingerprint", req.GetFingerprint())
return &sessionv1.GetSessionResponse{Valid: false}, nil
}

// Compare tenant IDs
if sess.TenantID != req.GetTenantId() {
span.SetStatus(codes.Ok, "tenant id mismatch")
Expand Down
36 changes: 0 additions & 36 deletions internal/grpc/session_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,42 +424,6 @@ func TestGetSession(t *testing.T) {
assert.Nil(t, resp)
})

t.Run("invalid - fingerprint mismatch", func(t *testing.T) {
sess := session.Session{
ID: "session-fingerprint",
TenantID: "tenant-fingerprint",
Fingerprint: "correct-fingerprint",
Issuer: "https://issuer.example.com",
}

sessionRepo := sessionmock.NewInMemRepository(
sessionmock.WithSession(sess),
)
_ = sessionRepo.BumpActive(ctx, sess.ID, 1*time.Hour)

mapping := trust.OIDCMapping{
IssuerURL: "https://issuer.example.com",
Blocked: false,
}
trustRepo := trustmock.NewInMemRepository(
trustmock.WithTrust(sess.TenantID, mapping),
)

server := grpc.NewSessionServer(ctx, sessionRepo, trustRepo, 90*time.Minute, "")

req := &sessionv1.GetSessionRequest{
SessionId: "session-fingerprint",
TenantId: "tenant-fingerprint",
Fingerprint: "wrong-fingerprint", // Mismatch
}

resp, err := server.GetSession(ctx, req)

require.NoError(t, err)
assert.NotNil(t, resp)
assert.False(t, resp.GetValid())
})

t.Run("invalid - tenant ID mismatch", func(t *testing.T) {
sess := session.Session{
ID: "session-tenant",
Expand Down
Loading