fix: Deprecate browser fingerprint.#306
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: alexey-medvedev-sap <alexey.medvedev02@sap.com> Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
84b443f to
97e6941
Compare
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
cb80
left a comment
There was a problem hiding this comment.
Two changes please:
- Please adjust the OpenAPI document at
api/session-manager.yaml(remove the fingerprint stuff from it) and afterwards runmake codegen - My comment below
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
Co-authored-by: Chris Burkert <burkert.chris@gmail.com> Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
Co-authored-by: Chris Burkert <burkert.chris@gmail.com> Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
8abbed2 to
1b4c0c8
Compare
fix: Deprecate browser fingerprint.
The current fingerprinting implementation is not beneficial and should be removed.