Skip to content

fix: Deprecate browser fingerprint.#306

Open
alexey-medvedev-sap wants to merge 11 commits into
mainfrom
fix/remove-fingerprint
Open

fix: Deprecate browser fingerprint.#306
alexey-medvedev-sap wants to merge 11 commits into
mainfrom
fix/remove-fingerprint

Conversation

@alexey-medvedev-sap

Copy link
Copy Markdown
Contributor

fix: Deprecate browser fingerprint.
The current fingerprinting implementation is not beneficial and should be removed.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9b7d7626-4f92-4dc9-a69d-aadaf2f4632d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@push-tags-from-workflow push-tags-from-workflow Bot added bug Something isn't working dependencies tests labels Jun 11, 2026
Signed-off-by: alexey-medvedev-sap <alexey.medvedev02@sap.com>
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
@alexey-medvedev-sap alexey-medvedev-sap marked this pull request as ready for review June 12, 2026 07:45
@alexey-medvedev-sap alexey-medvedev-sap requested a review from cb80 June 12, 2026 07:57

@cb80 cb80 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two changes please:

  1. Please adjust the OpenAPI document at api/session-manager.yaml (remove the fingerprint stuff from it) and afterwards run make codegen
  2. My comment below

Comment thread internal/session/manager.go Outdated
Comment thread internal/session/manager.go Outdated
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
alexey-medvedev-sap and others added 2 commits June 14, 2026 10:57
Co-authored-by: Chris Burkert <burkert.chris@gmail.com>
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
Co-authored-by: Chris Burkert <burkert.chris@gmail.com>
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
Signed-off-by: Alexey Medvedev <alexey.medvedev02@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api bug Something isn't working dependencies tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants