8388343: [lworld] Reevaluate the enable-preview in memory compilation from VM arguments

[liach]

When the JVM of javac runs with -J--enable-preview, javac should still compile against the non-preview class path when it is not passed --enable-preview. We have this hack within InMemoryJavaCompiler that turns out breaks things when we try to fix some javac issues (#2643), because we expect the output bytecode to be stable for transformations.

Turns out now this change is redundant. Tier 1-6 is clear so far except the known CreateCoreDumpOnCrash.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8388343: [lworld] Reevaluate the enable-preview in memory compilation from VM arguments (Bug - P4)

Reviewers

• Coleen Phillimore (@coleenp - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2645/head:pull/2645
$ git checkout pull/2645

Update a local copy of the PR:
$ git checkout pull/2645
$ git pull https://git.openjdk.org/valhalla.git pull/2645/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2645

View PR using the GUI difftool:
$ git pr show -t 2645

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2645.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8388343: [lworld] Reevaluate the enable-preview in memory compilation from VM arguments

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

• 53ef1bf: 8388372: [lworld] ProblemList runtime/cds/appcds/aotCache/AOTMapTest.java#valhalla in Xcomp mode

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (e91f9698)

[coleenp]

Reverting this looks fine. Thank you for verifying that the RedefineClasses tests pass with this change.

[liach]

I think I will hold this back from JEP 401 integration: test/jdk/java/io/Serializable/records/BadCanonicalCtrTest.java is being addressed on its own.

That said, I think we might still come back to this on mainline, because this breaks tests running with JTREG=JAVA_OPTIONS=--enable-preview if the test runs InMemoryJavaCompiler.compile with flags like "--release", "25".