Skip to content

8388192: [lworld] Some code is not guarded by Arguments::is_valhalla_enabled()#2640

Draft
TobiHartmann wants to merge 1 commit into
openjdk:lworldfrom
TobiHartmann:JDK-8388192
Draft

8388192: [lworld] Some code is not guarded by Arguments::is_valhalla_enabled()#2640
TobiHartmann wants to merge 1 commit into
openjdk:lworldfrom
TobiHartmann:JDK-8388192

Conversation

@TobiHartmann

@TobiHartmann TobiHartmann commented Jul 14, 2026

Copy link
Copy Markdown
Member

Some Valhalla specific code misses an Arguments::is_valhalla_enabled() check.

Thanks,
Tobias



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8388192: [lworld] Some code is not guarded by Arguments::is_valhalla_enabled() (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2640/head:pull/2640
$ git checkout pull/2640

Update a local copy of the PR:
$ git checkout pull/2640
$ git pull https://git.openjdk.org/valhalla.git pull/2640/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2640

View PR using the GUI difftool:
$ git pr show -t 2640

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2640.diff

@bridgekeeper

bridgekeeper Bot commented Jul 14, 2026

Copy link
Copy Markdown

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 14, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@chhagedorn chhagedorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, thanks!

@TobiHartmann

Copy link
Copy Markdown
Member Author

Thanks for the review Christian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants