Skip to content

8386451: [lworld] things to delete from lworld just before integrating JEP-401#2638

Open
dcubed-ojdk wants to merge 1 commit into
openjdk:lworldfrom
dcubed-ojdk:JDK-8386451
Open

8386451: [lworld] things to delete from lworld just before integrating JEP-401#2638
dcubed-ojdk wants to merge 1 commit into
openjdk:lworldfrom
dcubed-ojdk:JDK-8386451

Conversation

@dcubed-ojdk

@dcubed-ojdk dcubed-ojdk commented Jul 10, 2026

Copy link
Copy Markdown
Member

Trivial deletions from open lworld before integrating JEP-401:

  • Remove 'lworld' GHA support from .github/workflows/main.yml


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8386451: [lworld] things to delete from lworld just before integrating JEP-401 (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2638/head:pull/2638
$ git checkout pull/2638

Update a local copy of the PR:
$ git checkout pull/2638
$ git pull https://git.openjdk.org/valhalla.git pull/2638/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2638

View PR using the GUI difftool:
$ git pr show -t 2638

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2638.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 10, 2026

Copy link
Copy Markdown

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 10, 2026

Copy link
Copy Markdown

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8386451: [lworld] things to delete from lworld just before integrating JEP-401

Reviewed-by: coleenp, dsimms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 10, 2026
@mlbridge

mlbridge Bot commented Jul 10, 2026

Copy link
Copy Markdown

Webrevs

@coleenp coleenp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good also trivial.

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Jul 10, 2026
@dcubed-ojdk

Copy link
Copy Markdown
Member Author

@coleenp - Thanks for the review!

@liach

liach commented Jul 10, 2026

Copy link
Copy Markdown
Member

What about the changes elsewhere, like in .jcheck/conf?

@MrSimms

MrSimms commented Jul 11, 2026

Copy link
Copy Markdown
Member

What about the changes elsewhere, like in .jcheck/conf?

Already aligned to JDK in the PR (git diff jdk/master..MrSimms/8317277 -- .jcheck/conf / https://github.com/openjdk/jdk/pull/31120/changes). A number of changes in jcheck are project repo specific and can stay there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

4 participants