Skip to content

8387908: [s390x] Port JEP 401 to s390 architecture#2632

Open
offamitkumar wants to merge 30 commits into
openjdk:lworldfrom
offamitkumar:s390x-port
Open

8387908: [s390x] Port JEP 401 to s390 architecture#2632
offamitkumar wants to merge 30 commits into
openjdk:lworldfrom
offamitkumar:s390x-port

Conversation

@offamitkumar

@offamitkumar offamitkumar commented Jul 7, 2026

Copy link
Copy Markdown
Member

S390 port for valhalla, this is just dummy PR for review purposes. Once valhalla code is integrated into mainline, I will open a new PR against jdk/master.

Note

Issue being referred is not for lworld. This is intentional because final PR will be created against jdk/master branch;



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8387908: [s390x] Port JEP 401 to s390 architecture (Enhancement - P1)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2632/head:pull/2632
$ git checkout pull/2632

Update a local copy of the PR:
$ git checkout pull/2632
$ git pull https://git.openjdk.org/valhalla.git pull/2632/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2632

View PR using the GUI difftool:
$ git pr show -t 2632

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2632.diff

@bridgekeeper

bridgekeeper Bot commented Jul 7, 2026

Copy link
Copy Markdown

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 7, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@offamitkumar offamitkumar changed the title s390-port 8387908 Jul 7, 2026
@openjdk openjdk Bot changed the title 8387908 8387908: [s390x] Port JEP 401 to s390 architecture Jul 7, 2026
@offamitkumar
offamitkumar marked this pull request as ready for review July 9, 2026 08:15
@offamitkumar
offamitkumar marked this pull request as draft July 13, 2026 05:27
@offamitkumar
offamitkumar marked this pull request as ready for review July 13, 2026 05:29
@offamitkumar

Copy link
Copy Markdown
Member Author

Further work is going on here : https://github.com/offamitkumar/valhalla/tree/s390-valhalla-loom ; Right now I am working on enabling the valhalla optimisations.

Changes might be included into this PR or probably a separate PR will be raised, as this is stable already.

//
// TODO (s390x): validate slot offset against frame layout once
// InlineTypePassFieldsAsArgs is enabled on s390x.
ShouldNotCallThis(); // poison: remove once validated on s390x

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is optimisation InlineTypePassFieldsAsArgs which is not yet enabled on s390x, with that this would be cleaned up.

For now idea is to provide a very minimal support for Valhalla, which will prevent the build break and all of tier1 tests, excluding Valhalla-specific ones, should be passing.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the comment needs to be clear about that. In particular, you need to explain why the poisoned code is unreachable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants