8387908: [s390x] Port JEP 401 to s390 architecture#2632
Conversation
|
👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
Further work is going on here : https://github.com/offamitkumar/valhalla/tree/s390-valhalla-loom ; Right now I am working on enabling the valhalla optimisations. Changes might be included into this PR or probably a separate PR will be raised, as this is stable already. |
| // | ||
| // TODO (s390x): validate slot offset against frame layout once | ||
| // InlineTypePassFieldsAsArgs is enabled on s390x. | ||
| ShouldNotCallThis(); // poison: remove once validated on s390x |
There was a problem hiding this comment.
This is optimisation InlineTypePassFieldsAsArgs which is not yet enabled on s390x, with that this would be cleaned up.
For now idea is to provide a very minimal support for Valhalla, which will prevent the build break and all of tier1 tests, excluding Valhalla-specific ones, should be passing.
There was a problem hiding this comment.
Then the comment needs to be clear about that. In particular, you need to explain why the poisoned code is unreachable.
S390 port for valhalla, this is just dummy PR for review purposes. Once valhalla code is integrated into mainline, I will open a new PR against jdk/master.
Note
Issue being referred is not for lworld. This is intentional because final PR will be created against jdk/master branch;
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2632/head:pull/2632$ git checkout pull/2632Update a local copy of the PR:
$ git checkout pull/2632$ git pull https://git.openjdk.org/valhalla.git pull/2632/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2632View PR using the GUI difftool:
$ git pr show -t 2632Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2632.diff