Skip to content

8385112: [lworld] 8369044 fix missing for arm and ppc#2605

Open
PeyaPeyaPeyang wants to merge 1 commit into
openjdk:lworldfrom
PeyaPeyaPeyang:8385112-correct-arm-and-ppc
Open

8385112: [lworld] 8369044 fix missing for arm and ppc#2605
PeyaPeyaPeyang wants to merge 1 commit into
openjdk:lworldfrom
PeyaPeyaPeyang:8385112-correct-arm-and-ppc

Conversation

@PeyaPeyaPeyang

@PeyaPeyaPeyang PeyaPeyaPeyang commented Jun 30, 2026

Copy link
Copy Markdown
Member

Hi there,

I (re)checked the other TemplateTable::_return implementations as well.

ARM looks like it was simply missed, so I added the same check for _return and _return_register_finalizer there as well1.

For PPC, I left it unchanged.
Its _return implementation already emits a StoreStore barrier in the later switch when state == vtos.
Since also _return_register_finalizer is a vtos return, that case is already covered there.

The other implementations look good to me.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8385112: [lworld] 8369044 fix missing for arm and ppc (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2605/head:pull/2605
$ git checkout pull/2605

Update a local copy of the PR:
$ git checkout pull/2605
$ git pull https://git.openjdk.org/valhalla.git pull/2605/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2605

View PR using the GUI difftool:
$ git pr show -t 2605

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2605.diff

Using Webrev

Link to Webrev Comment

Footnotes

  1. https://github.com/openjdk/valhalla/pull/1652/changes/dc20997b6136882ff11dc7bcd255ac15198e0aca

@bridgekeeper

bridgekeeper Bot commented Jun 30, 2026

Copy link
Copy Markdown

👋 Welcome back dyama! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 30, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 30, 2026
@mlbridge

mlbridge Bot commented Jun 30, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant