8385112: [lworld] 8369044 fix missing for arm and ppc#2605
Open
PeyaPeyaPeyang wants to merge 1 commit into
Open
8385112: [lworld] 8369044 fix missing for arm and ppc#2605PeyaPeyaPeyang wants to merge 1 commit into
PeyaPeyaPeyang wants to merge 1 commit into
Conversation
|
👋 Welcome back dyama! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I (re)checked the other
TemplateTable::_returnimplementations as well.ARM looks like it was simply missed, so I added the same check for
_returnand_return_register_finalizerthere as well1.For PPC, I left it unchanged.
Its
_returnimplementation already emits aStoreStorebarrier in the later switch whenstate == vtos.Since also
_return_register_finalizeris avtosreturn, that case is already covered there.The other implementations look good to me.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2605/head:pull/2605$ git checkout pull/2605Update a local copy of the PR:
$ git checkout pull/2605$ git pull https://git.openjdk.org/valhalla.git pull/2605/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2605View PR using the GUI difftool:
$ git pr show -t 2605Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2605.diff
Using Webrev
Link to Webrev Comment
Footnotes
https://github.com/openjdk/valhalla/pull/1652/changes/dc20997b6136882ff11dc7bcd255ac15198e0aca ↩