8384109: [lworld] Update NegativeArraySizeExceptionTest to check arrays of value classes#2422
8384109: [lworld] Update NegativeArraySizeExceptionTest to check arrays of value classes#2422shivshah-oracle wants to merge 6 commits into
Conversation
|
👋 Welcome back shivshah-oracle! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Webrevs
|
lmesnik
left a comment
There was a problem hiding this comment.
just question, it is possible to reduce code duplication and merge it with existing test sources?
|
|
||
| public class NegativeArraySizeExceptionTest { | ||
|
|
||
| @AsValueClass | ||
| static class Point { | ||
| int x; |
There was a problem hiding this comment.
Might be better to have VClass then point
and
have "flattned" value fields (Integer) instead of int
| @@ -301,6 +323,19 @@ public static void main(String[] args) throws Exception { | |||
| Asserts.assertEQ("-2147483648", e.getMessage()); | |||
| } | |||
|
|
|||
|
|
|||
| // Tests for value class arrays (migrated Integer and custom Point). | |||
|
@shivshah-oracle This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
@shivshah-oracle This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Added value class variants for NegativeArraySizeException tests, migrated types (Integer) and custom value classes (Point) with @enablePreview.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2422/head:pull/2422$ git checkout pull/2422Update a local copy of the PR:
$ git checkout pull/2422$ git pull https://git.openjdk.org/valhalla.git pull/2422/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2422View PR using the GUI difftool:
$ git pr show -t 2422Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2422.diff
Using Webrev
Link to Webrev Comment