Skip to content

8381379: Support std/dstOffset attributes in CLDR's metazone definitions - #762

Closed
rm-gh-8 wants to merge 1 commit into
openjdk:pr/752from
rm-gh-8:JDK-8381379-V25
Closed

8381379: Support std/dstOffset attributes in CLDR's metazone definitions#762
rm-gh-8 wants to merge 1 commit into
openjdk:pr/752from
rm-gh-8:JDK-8381379-V25

Conversation

@rm-gh-8

@rm-gh-8 rm-gh-8 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Backporting JDK-8381379: Support std/dstOffset attributes in CLDR's metazone definitions.

This PR fixes the time zone name formatting for zones like Europe/Dublin by following the explicit metazone dstOffset attribute.

This PR is not clean because of a merge conflict in the copyright header in DateTimeFormatterBuilder.java and a merge conflict in the bug list of TimeZoneNamesTest.java, due to skipped commits relating to CLDR 48+ which is not in Java 25.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/sun/util/resources/cldr

Results:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8381379 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #752 must be integrated first

Issue

  • JDK-8381379: Support std/dstOffset attributes in CLDR's metazone definitions (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/762/head:pull/762
$ git checkout pull/762

Update a local copy of the PR:
$ git checkout pull/762
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/762/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 762

View PR using the GUI difftool:
$ git pr show -t 762

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/762.diff

Using Webrev

Link to Webrev Comment

@rm-gh-8
rm-gh-8 marked this pull request as ready for review August 26, 2026 13:15
@bridgekeeper

bridgekeeper Bot commented Aug 26, 2026

Copy link
Copy Markdown

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into pr/752 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 26, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 13633c0825cc44e7a40b652b3c70334d1cfa621e 8381379: Support std/dstOffset attributes in CLDR's metazone definitions Aug 26, 2026
@openjdk

openjdk Bot commented Aug 26, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 26, 2026
@mlbridge

mlbridge Bot commented Aug 26, 2026

Copy link
Copy Markdown

Webrevs

@shipilev

shipilev commented Aug 26, 2026

Copy link
Copy Markdown
Member

I see that @gnu-andrew was first to publish: #757. I suggest to close this PR and cooperate in the first one. You are in the perfect position to cross-check Andrew's work :)

@rm-gh-8

rm-gh-8 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

@shipilev Please take a look at #752 . This is a dependent PR.

@rm-gh-8

rm-gh-8 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

This matters to us, so I'll keep it open until the duplicate has been merged.

@rm-gh-8

rm-gh-8 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Discussed offline. Withdrawing PR due to duplication.

@rm-gh-8 rm-gh-8 closed this Aug 27, 2026
@gnu-andrew

Copy link
Copy Markdown
Member

I see that @gnu-andrew was first to publish: #757. I suggest to close this PR and cooperate in the first one. You are in the perfect position to cross-check Andrew's work :)

Thanks. I've been watching the tzdata bug for a while (see my comments there) and wasn't aware anyone else was working on it. Still plenty to do on backports to the older JDKs too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants