8381379: Support std/dstOffset attributes in CLDR's metazone definitions - #762
8381379: Support std/dstOffset attributes in CLDR's metazone definitions#762rm-gh-8 wants to merge 1 commit into
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
I see that @gnu-andrew was first to publish: #757. I suggest to close this PR and cooperate in the first one. You are in the perfect position to cross-check Andrew's work :) |
|
This matters to us, so I'll keep it open until the duplicate has been merged. |
|
Discussed offline. Withdrawing PR due to duplication. |
Thanks. I've been watching the tzdata bug for a while (see my comments there) and wasn't aware anyone else was working on it. Still plenty to do on backports to the older JDKs too. |
Backporting JDK-8381379: Support std/dstOffset attributes in CLDR's metazone definitions.
This PR fixes the time zone name formatting for zones like Europe/Dublin by following the explicit metazone dstOffset attribute.
This PR is not clean because of a merge conflict in the copyright header in DateTimeFormatterBuilder.java and a merge conflict in the bug list of TimeZoneNamesTest.java, due to skipped commits relating to CLDR 48+ which is not in Java 25.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/sun/util/resources/cldr
Results:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/762/head:pull/762$ git checkout pull/762Update a local copy of the PR:
$ git checkout pull/762$ git pull https://git.openjdk.org/jdk25u-dev.git pull/762/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 762View PR using the GUI difftool:
$ git pr show -t 762Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/762.diff
Using Webrev
Link to Webrev Comment