Skip to content

8372044: Implementation Review Based on ML-KEM Security Considerations - #755

Open
stooke wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-stooke-bcbde75d-master
Open

8372044: Implementation Review Based on ML-KEM Security Considerations#755
stooke wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-stooke-bcbde75d-master

Conversation

@stooke

@stooke stooke commented Aug 25, 2026

Copy link
Copy Markdown

I would like to backport this enhancement to JDK25 as part of a series of Post Quantum Cryptography PRs. This PR enhances the security of the ML-KEM implementation so should be part of this ongoing effort.

Medium to low risk.

[Testing]
Tier 2 tests pass, except for several network related tests that also fail in the master branch on my machine.
Specifically, acvp/Launcher.java passes with the ACVP-Server-1.1.0.38 bundle supplied.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8372044 needs maintainer approval

Issue

  • JDK-8372044: Implementation Review Based on ML-KEM Security Considerations (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/755/head:pull/755
$ git checkout pull/755

Update a local copy of the PR:
$ git checkout pull/755
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/755/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 755

View PR using the GUI difftool:
$ git pr show -t 755

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/755.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 25, 2026

Copy link
Copy Markdown

👋 Welcome back stooke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 25, 2026

Copy link
Copy Markdown

@stooke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372044: Implementation Review Based on ML-KEM Security Considerations

You can use pull request commands such as /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 2dda74a: 8390654: Test gc/TestUseGCOverheadLimit.java#G1 fails on linux-arm32
  • e7f701f: 8390033: Disable stringop-overflow in shenandoahHeap.cpp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport bcbde75d4e73de8385e39344e5737c1f82907541 8372044: Implementation Review Based on ML-KEM Security Considerations Aug 25, 2026
@openjdk

openjdk Bot commented Aug 25, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels Aug 25, 2026
@mlbridge

mlbridge Bot commented Aug 25, 2026

Copy link
Copy Markdown

Webrevs

@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant