8372044: Implementation Review Based on ML-KEM Security Considerations - #755
8372044: Implementation Review Based on ML-KEM Security Considerations#755stooke wants to merge 1 commit into
Conversation
|
👋 Welcome back stooke! A progress list of the required criteria for merging this PR into |
|
@stooke This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
I would like to backport this enhancement to JDK25 as part of a series of Post Quantum Cryptography PRs. This PR enhances the security of the ML-KEM implementation so should be part of this ongoing effort.
Medium to low risk.
[Testing]
Tier 2 tests pass, except for several network related tests that also fail in the master branch on my machine.
Specifically, acvp/Launcher.java passes with the ACVP-Server-1.1.0.38 bundle supplied.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/755/head:pull/755$ git checkout pull/755Update a local copy of the PR:
$ git checkout pull/755$ git pull https://git.openjdk.org/jdk25u-dev.git pull/755/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 755View PR using the GUI difftool:
$ git pr show -t 755Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/755.diff
Using Webrev
Link to Webrev Comment