Skip to content

8354305: SHAKE128 and SHAKE256 MessageDigest algorithms#4580

Open
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8354305-V17
Open

8354305: SHAKE128 and SHAKE256 MessageDigest algorithms#4580
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8354305-V17

Conversation

@rm-gh-8

@rm-gh-8 rm-gh-8 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Backporting JDK-8354305: SHAKE128 and SHAKE256 MessageDigest algorithms.

This PR adds SHAKE128-256/SHAKE256-512 as standard MessageDigest algorithms.

For parity with Oracle JDK. Already backported to 21.

This PR will not build successfully. It requires a fix from JDK-8356051, which is a dependent PR(#4581).



Progress

  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8386841 to be approved
  • Commit message must refer to an issue
  • JDK-8354305 needs maintainer approval

Issues

  • JDK-8354305: SHAKE128 and SHAKE256 MessageDigest algorithms (Enhancement - P3 - Requested)
  • JDK-8386841: SHAKE128 and SHAKE256 MessageDigest algorithms (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4580/head:pull/4580
$ git checkout pull/4580

Update a local copy of the PR:
$ git checkout pull/4580
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4580/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4580

View PR using the GUI difftool:
$ git pr show -t 4580

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4580.diff

Using Webrev

Link to Webrev Comment

@rm-gh-8
rm-gh-8 marked this pull request as ready for review July 22, 2026 12:40
@bridgekeeper

bridgekeeper Bot commented Jul 22, 2026

Copy link
Copy Markdown

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 22, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 494ef6cb8cff7f29a7346364e7620eebcec48d3b 8354305: SHAKE128 and SHAKE256 MessageDigest algorithms Jul 22, 2026
@openjdk

openjdk Bot commented Jul 22, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 22, 2026
@openjdk

openjdk Bot commented Jul 22, 2026

Copy link
Copy Markdown

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 22, 2026
@mlbridge

mlbridge Bot commented Jul 22, 2026

Copy link
Copy Markdown

Webrevs

@rm-gh-8

rm-gh-8 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

/approval request for backport of JDK-8354305: SHAKE128 and SHAKE256 MessageDigest algorithms.

This PR adds SHAKE128-256/SHAKE256-512 as standard MessageDigest algorithms.

For parity with Oracle JDK. Already backported to 21.

This PR will not build successfully. It requires a fix from JDK-8356051, which is a dependent PR (#4581).

Low Risk (contingent on the dependent PR) - the changes are additive

@openjdk

openjdk Bot commented Jul 22, 2026

Copy link
Copy Markdown

@rm-gh-8
8354305: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant