8354305: SHAKE128 and SHAKE256 MessageDigest algorithms#4580
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8354305: SHAKE128 and SHAKE256 MessageDigest algorithms. This PR adds SHAKE128-256/SHAKE256-512 as standard MessageDigest algorithms. For parity with Oracle JDK. Already backported to 21. This PR will not build successfully. It requires a fix from JDK-8356051, which is a dependent PR (#4581). Low Risk (contingent on the dependent PR) - the changes are additive |
Backporting JDK-8354305: SHAKE128 and SHAKE256 MessageDigest algorithms.
This PR adds SHAKE128-256/SHAKE256-512 as standard MessageDigest algorithms.
For parity with Oracle JDK. Already backported to 21.
This PR will not build successfully. It requires a fix from JDK-8356051, which is a dependent PR(#4581).
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4580/head:pull/4580$ git checkout pull/4580Update a local copy of the PR:
$ git checkout pull/4580$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4580/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4580View PR using the GUI difftool:
$ git pr show -t 4580Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4580.diff
Using Webrev
Link to Webrev Comment