Building Interactive Authorization on top of first party apps draft#736
Open
mickrau wants to merge 11 commits into
Open
Building Interactive Authorization on top of first party apps draft#736mickrau wants to merge 11 commits into
mickrau wants to merge 11 commits into
Conversation
fkj
reviewed
May 18, 2026
fkj
left a comment
fkj
left a comment
Member
There was a problem hiding this comment.
Generally I think this is really nice! It does not feel like a hack, but quite natural. I also think it reads pretty well. I've added a lot of nits and some points for discussion.
@mickrau It would be great if you could take a look and merge the ones you agree with/discard the ones you don't. Sorry it took me so long to review this!
Co-authored-by: Frederik Krogsdal Jacobsen <fkj@users.noreply.github.com>
GarethCOliver
approved these changes
May 18, 2026
ju-cu
reviewed
Jun 3, 2026
paulbastian
reviewed
Jun 4, 2026
gffletch
reviewed
Jun 4, 2026
paulbastian
reviewed
Jun 4, 2026
paulbastian
reviewed
Jun 4, 2026
mickrau
commented
Jun 9, 2026
mickrau
commented
Jun 9, 2026
mickrau
commented
Jun 9, 2026
mickrau
commented
Jun 9, 2026
mickrau
commented
Jun 9, 2026
Co-authored-by: Judith <59833642+ju-cu@users.noreply.github.com> Co-authored-by: Paul Bastian <paul.bastian@posteo.de> Co-authored-by: Micha Kraus <7931215+mickrau@users.noreply.github.com>
Contributor
Author
|
Thank you for the feedback. I have resolved most of the suggestions. Aside from a few editorial todos, there are two open questions left to address:
|
Member
I think yes, since people might forget about the URN prefix and think it's the same thing. A completely different name avoids confusion.
I think 401 makes more sense when considering the HTTP semantics. |
paulbastian
reviewed
Jun 17, 2026
Co-authored-by: Micha Kraus <7931215+mickrau@users.noreply.github.com>
paulbastian
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rough draft for further discussion.
Changes (among others):
status= (require_interaction|ok) and use (HTTP 401 witherror:insufficient_authorization) and (HTTP 200 +authorization_code) insteadI kept the order of the sections so that you can see at a glance what has changed.