Skip to content

fix: leave new dropdown answers empty instead of "undefined" [backport to verawood] #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradenmacdonald merged 1 commit into from
Aug 31, 2026
Merged

fix: leave new dropdown answers empty instead of "undefined" [backport to verawood] #3217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/editors/containers/ProblemEditor/data/OLXParser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ export class OLXParser {
const preservedFeedback = preservedAnswers[index].filter(answer =>
Object.keys(answer).includes(`${option}hint`)
);
let title = String(element['#text']);
let title = String(element['#text'] ?? '');

if (isComplexAnswer && preservedAnswer) {
title = this.richTextBuilder.build(preservedAnswer);
Expand All @@ -281,7 +281,7 @@ export class OLXParser {
} else {
const preservedAnswer = preservedAnswers[0].filter(answer => !Object.keys(answer).includes(`${option}hint`));
const preservedFeedback = preservedAnswers[0].filter(answer => Object.keys(answer).includes(`${option}hint`));
let title = String(choice['#text']);
let title = String(choice['#text'] ?? '');

if (isComplexAnswer && preservedAnswer) {
title = this.richTextBuilder.build(preservedAnswer);
Expand Down
8 changes: 8 additions & 0 deletions src/editors/containers/ProblemEditor/data/OLXParser.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import dropdownTemplate from '@src/editors/data/constants/basicProblemTemplates/dropdown';
import { OLXParser } from './OLXParser';
import {
checkboxesOLXWithFeedbackAndHintsOLX,
Expand Down Expand Up @@ -134,6 +135,13 @@ describe('OLXParser', () => {
expect(problemType).toEqual(ProblemTypeKeys.NUMERIC);
});
});
describe('given the blank dropdown template', () => {
const olxparser = new OLXParser(dropdownTemplate.olx);
const { answers } = olxparser.parseMultipleChoiceAnswers('optionresponse', 'optioninput', 'option');
it('should leave every answer empty, so the editor shows its placeholder', () => {
expect(answers.map(answer => answer.title)).toEqual(['', '', '']);
});
});
describe('given dropdown olx with feedback and hints', () => {
const problemType = dropdownOlxParser.getProblemType();
it('should equal ProblemTypeKeys.DROPDOWN', () => {
Expand Down