feat: PDF auto-conversion - #3201
Conversation
|
Thanks for the pull request, @Kelketek! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| id: 'authoring.pdfEditor.formGroups.downloadOptions.sourceUrl.hint', | ||
| defaultMessage: 'Add a link to the original or editable file (e.g. Word or PowerPoint). Appears as a separate link.', | ||
| defaultMessage: 'Add a link to the original or editable file (e.g. Word or PowerPoint). Appears as a separate ' | ||
| + 'link. You are strongly recommended to include this as PDFs have significant accessibility limitations.', |
There was a problem hiding this comment.
PDFs can be made as accessible (or not) as Word or PowerPoint files. I suggest a more general reminder that uploaded files need to be made natively accessible, or also upload clearly identified conforming alternative versions.
There was a problem hiding this comment.
@wittjeff Looked into it and you're right. I've only ever thought of PDFs as a postscript format for printers and every attempt I've had to try to extract useful text from them tends to be frustrating, but the format supports much better accessibility than I realized.
I've updated the phrasing here. Let me know if it works for you.
0ee344e to
5c633d5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3201 +/- ##
==========================================
+ Coverage 95.91% 95.95% +0.03%
==========================================
Files 1397 1397
Lines 33558 33607 +49
Branches 7914 7681 -233
==========================================
+ Hits 32187 32246 +59
- Misses 1312 1317 +5
+ Partials 59 44 -15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5c633d5 to
286cc00
Compare
286cc00 to
ff9a08c
Compare
Description
This merge request enables auto-conversion of documents to PDF, provided the Gotenberg service is installed and configured.
Supporting information
Testing instructions
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'