Add allocation window equivalence test#110
Open
Noah-Philip wants to merge 2 commits into
Open
Conversation
Signed-off-by: noah-philip <noahphilip06@outlook.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new OpenCost integration test that validates allocation window-parsing consistency. For each supported keyword window (today, yesterday, week, 14d), it queries /allocation, rebuilds an equivalent explicit RFC3339 range from the API-returned window, re-queries, and asserts the summed totalCost matches within absolute/relative tolerances. It fits alongside the existing window-related tests (e.g., correct_window_values_test.go) in the allocation integration suite.
Changes:
- Adds
allocation_window_equivalence_test.goimplementingTestAllocationKeywordAndExplicitWindowsEquivalentwith self-contained helpers for fetching, summing, window extraction, RFC3339 formatting, and tolerance comparison. - Registers the new test in
test.batsso it runs as part of the allocation suite.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/integration/api/allocation/allocation_window_equivalence_test.go |
New integration test comparing keyword vs. explicit RFC3339 window allocation totals with tolerance handling. |
test/integration/api/allocation/test.bats |
Adds a bats entry to execute the new equivalence test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: noah-philip <noahphilip06@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an allocation window parsing consistency test.
The test queries
/allocationusing supported keyword windows:todayyesterdayweekFor each keyword window, it builds an equivalent explicit RFC3339 range from the response window and verifies that the explicit range returns a consistent allocation total.
Implementation
aggregate=namespace,accumulate=true, andincludeIdle=truetotalCostbetween keyword and explicit range responsesTesting
go test -count=1 ./test/integration/api/allocation -run TestAllocationKeywordAndExplicitWindowsEquivalent -vbats test/integration/api/allocation/test.bats