Skip to content

Fix various typos/grammar - #11

Open
luzpaz wants to merge 1 commit into
opencomputeproject:masterfrom
luzpaz:typos
Open

Fix various typos/grammar#11
luzpaz wants to merge 1 commit into
opencomputeproject:masterfrom
luzpaz:typos

Conversation

@luzpaz

@luzpaz luzpaz commented Nov 19, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@vejmarie

Copy link
Copy Markdown
Member

Hi @luzpaz

Thanks for your PR. My english is not as good as it should be ;). Quick question do you mind signing your commit ? You can do that through git -s --amend. You can sign through a GPG key or public / private key. We are doing this to keep track of code committers in the case we need to get in touch with them, and we would like to avoid that people steal potential identities ;) in the case your github account got hacked. That is the only one constraint that we have.

vejmarie

@luzpaz

luzpaz commented Nov 20, 2020

Copy link
Copy Markdown
Contributor Author

i don't have a GPG key. Can i use my ssh public key ?

@vejmarie

Copy link
Copy Markdown
Member

I don't think so, You need a GPG key to sign commit. Setting it up is easy whatever the O/S you use, you can follow the guideline here

https://github.com/settings/keys .

The ssh key is used to simplify your authentication but not to sign your commit unfortunately. I was also reluctant to do it up to the time I discovered that it was pretty easy to "steal" your identity and got an "homonym" who started to push code with my nickname.

@luzpaz

luzpaz commented Nov 20, 2020

Copy link
Copy Markdown
Contributor Author

Then just feel free to cherrypick the commits and erase all my info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants