feat(api): Batch StreamForecastData responses#163
Merged
Conversation
Benchmark ResultsBenchmark resultsBenchmark vs base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Checklist
make lintwith your changes locally?make testwith your changes locally?Warning
PRs may be closed if all the above boxes are not checked.
Changes in this Pull Request
Modifies the StreamForecastData route to return its values in batches. This should be more stable and reduce CPU usage a bit. It does introduce a breaking change to the API, but since the Stream route is not on any hot path, I don't mind doing this. This is still in pre-1.0.0 after all.
The change is reflected in the example.py file, and boils down to data from the stream being under a
valuesfield, when previously it was returned top-level.