fix(sync): try full app-state sync before recovery - #369
Open
goutamadwant wants to merge 1 commit into
Open
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #367
What changed
Why
The sync error handler previously jumped directly to
RequestAppStateRecovery. That skipped the cheaper local full-sync reset and could leave a collection stuck when the primary device did not answer the snapshot request.Behavior proof
Before the fix, the focused regression failed because no full-sync call occurred and the recovery request fired immediately. After the fix, the fake transport records exactly one
FetchAppState(..., fullSync=true, onlyIfNotSynced=false)call per collection. A repeated LTHash mismatch then produces one recovery request, while a successful full sync and a non-LTHash full-sync failure produce none.Validation
Limitations
No live WhatsApp account was used. The repository's fake transport exercises the full-sync and recovery-request boundary deterministically without provider mutation.
Disclosure: AI was used to understand the codebase and review the fix.