feat(native-eval): export tool discovery telemetry - #60
Conversation
|
Codex review: needs changes before merge. Reviewed August 22, 2026, 4:06 PM ET / 20:06 UTC. ClawSweeper reviewWhat this changesThe PR adds normalized native-harness discovery telemetry exports and trace-fidelity metadata to ShellBench research-audit CSVs. Merge readinessKeep open: the earlier P2 blocker remains on the unchanged head. Missing discovery configuration and events are still recorded as Priority: P2 Review scores
Verification
Live VerificationCommand: Result: FAIL (failed) — execution before step 1 Assertions:
How this fits togetherThe native-evaluation research audit reads completed harness trajectories and manifests, then exports CSV inventories used to compare tool use across harnesses. Discovery telemetry is extracted, normalized, classified, and written to trace and discovery-event outputs. flowchart LR
A[Harness trajectory] --> B[Research audit]
C[Run manifest and config] --> B
B --> D[Discovery telemetry extraction]
D --> E[Counter normalization]
E --> F[Discovery status classification]
F --> G[Trace inventory CSV]
E --> H[Discovery events CSV]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Preserve absent configuration and events as unobservable unless explicit runner metadata proves discovery was disabled, then document the status contract for CSV consumers. Do we have a high-confidence way to reproduce the issue? Yes. A run with no Is this the best way to solve the issue? No. The export approach is useful, but its classifier must preserve missing evidence as unobservable and state that contract before researchers consume the data. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 884dd1bb5511. LabelsLabel justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (73 earlier review cycles; latest 8 shown)
|
What does this PR do?
Exports native-harness tool discovery operations separately from final tool
calls and records the trace fidelity needed to interpret missing events.
Why?
Fixes #59.
The existing research audit records
tool_search_codeas one wrapper call butdrops OpenClaw's embedded catalog and search/describe/call counters. It also
cannot distinguish disabled discovery from unsupported or unobservable native
events, which makes cross-harness comparisons produce fake zeros.
Changes
discovery_events.csvwith normalized search, describe, and call countsTests
python -m pytest -q tests/test_native_eval_research_audit.pypython -m ruff check scripts/native_eval/research_audit.py tests/test_native_eval_research_audit.pyall three tasks report the expected runner SHA, session fidelity,
disableddiscovery state, and zero discovery operations