fix: apply native reasoning effort to harnesses - #54
Conversation
|
Codex review: needs changes before merge. Reviewed August 22, 2026, 5:56 AM ET / 09:56 UTC. ClawSweeper reviewWhat this changesThe PR propagates planned reasoning effort into OpenClaw, Hermes, Codex, and Claude Code harness commands, run specifications, and run manifests. Merge readinessKeep this member-authored PR open: it still contains the previously reported P1 precedence split, which can make the harness command and manifest report a CLI effort different from the already-started proxy's effort. Priority: P1 Review scores
Verification
Live VerificationCommand: Result: FAIL (failed) — execution before step 1 Assertions:
How this fits togetherShellBench turns a native evaluation plan into a fleet-dispatched run, starts a LiteLLM provider proxy, then launches the selected agent harness. The proxy, harness command, and run manifest must use one reasoning-effort value for benchmark results to be comparable. flowchart LR
A[Evaluation plan] --> B[Fleet dispatch]
B --> C[Provider environment]
C --> D[LiteLLM proxy]
B --> E[Run specification]
E --> F[Native harness command]
E --> G[Run manifest]
D --> H[Comparable benchmark result]
F --> H
G --> H
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Keep the native harness mappings, but establish one canonical reasoning-effort value before LiteLLM configuration and use that same value for proxy, harness, and manifest output. Do we have a high-confidence way to reproduce the issue? Yes. With SHELLBENCH_REASONING_EFFORT=low and --reasoning-effort high, source shows the proxy is configured first from low while the subsequent run specification, harness command, and manifest use high. Is this the best way to solve the issue? No. The harness mappings are appropriate, but the added precedence path must be unified with proxy startup or fail on a conflict before this is a safe benchmark fix. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 884dd1bb5511. LabelsLabel changes:
Label justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (72 earlier review cycles; latest 8 shown)
|
What does this PR do?
Propagates the native eval plan's reasoning effort into OpenClaw, Hermes,
Codex, and Claude Code client controls.
Why?
Fixes #53. Without this, a run can be labeled
highwhile OpenClaw executeswith thinking disabled, invalidating cross-harness quality and efficiency
comparisons.
Changes
reasoning_effortinRunSpecand the run manifestxhighto Claude Code'smaxlow,medium,high, andxhighacross all four harnessesTests