fix: accept Claude native trajectories - #52
Conversation
|
Codex review: needs maintainer review before merge. Reviewed August 21, 2026, 7:55 PM ET / 23:55 UTC. ClawSweeper reviewWhat this changesThe PR adds Claude Code to ShellBench’s real-trajectory harness policy and tests that all pinned native harnesses report real harness events. Merge readinessKeep open for an explicit maintainer decision: current main reconstructs Claude Code traces but still classifies the harness as unsupported, and this PR changes that benchmark-evidence policy to make qualifying runs eligible for aggregation. Priority: P2 Review scores
Verification
Live VerificationCommand: Result: FAIL (failed) — execution before step 1 Assertions:
How this fits togetherShellBench’s native evaluator converts each harness’s raw run output into a normalized trajectory and records its evidence mode in the run manifest. Aggregation uses that mode plus per-task trajectory checks to decide whether a run can contribute to native benchmark results. flowchart LR
A[Claude Code native run] --> B[Stream JSON log]
B --> C[Trajectory reconstruction]
C --> D{Evidence-mode policy}
D --> E[Aggregate eligibility]
E --> F[Native benchmark results]
Decision needed
Why: The patch is mechanically narrow, but the allowlist is an evidence-policy boundary rather than a purely technical parser correction. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Approve the existing Claude Code reconstruction as real benchmark evidence only if its retained raw events, terminal-state check, and canonical-model gate meet the intended comparability standard; otherwise retain the conservative exclusion. Do we have a high-confidence way to reproduce the issue? Yes, from current source: a Claude Code run can reconstruct to a real trajectory, but current main assigns its manifest an unsupported mode, which aggregation treats as trajectory-unavailable. Is this the best way to solve the issue? Unclear pending maintainer policy judgment; adding Claude Code is the narrowest implementation if its reconstructed events meet the same evidence standard as the other accepted harnesses. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 884dd1bb5511. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (64 earlier review cycles; latest 8 shown)
|
What does this PR do?
Marks Claude Code native trajectories as real harness events so completed Claude runs remain eligible for native aggregation.
Why?
The native runner already converts Claude Code
stream-jsonoutput intotrajectory.json, but the harness allowlist omittedclaude-code. Aggregation therefore classified otherwise valid Claude runs astrajectory_unavailable.Changes
claude-codeto the real-trajectory harness allowlistreal_harness_eventsLive proof
A native Claude Code control run completed four tasks with four result files, four valid completed results, and no infrastructure failures. Aggregation classified every trajectory as
real; the run remained ineligible only because it was intentionally marked as an exploratory four-task subset.4/40.753truerealfor all four tasks0exploratory_subsetTests
python -m pytest -qpasses locally (444 passed, 5 skipped)python -m ruff check clawbench app.py scripts testspasses locally