fix: clarify notification alarms and native Urgent - #80
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Verified head
This completes #79's requested documentation fallback. There is no native Urgent flag because the public EventKit SDK does not expose that control. Release-note credit for @Amitdvl is in #82, which should land last. |
|
Codex review: needs maintainer review before merge. Reviewed September 7, 2026, 5:19 AM ET / 09:19 UTC. ClawSweeper reviewWhat this changesClarifies add/edit help and command documentation that notification alarms do not enable Reminders.app’s native Urgent toggle. Merge readiness✅ Ready for maintainer review This PR remains useful: the requested CLI guidance is absent from main and v0.3.5. The focused clarification satisfies the reporter’s documentation fallback, and no blocking defect was found. Priority: P3 Review scores
Verification
How this fits togetherremindctl manages Apple Reminders through public EventKit APIs. Its command help explains available options before users create or edit reminders. flowchart TD
A[Command arguments] --> B{Help requested?}
B -->|Yes| C[Add or edit help]
C --> D[Notification and Urgent guidance]
B -->|No| E[Reminder command]
E --> F[EventKit notification alarm]
Before mergeNone. Agent review detailsSecurityNone. Review metricsNone. Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Technical reviewBest possible solution: Keep command help consistent with the documented public-EventKit boundary and direct users to Reminders.app for native Urgent. Do we have a high-confidence way to reproduce the issue? Not applicable to a documentation clarification; source comparison establishes the missing guidance, and the supplied CLI output demonstrates it after the change. Is this the best way to solve the issue? Yes. Updating the existing help and command documentation satisfies the reporter’s accepted fallback without adding unsupported APIs or changing alarm behavior. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against b366b1449e63. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
Collect the complete Unreleased notes for the next patch after v0.3.5: native Urgent guidance from #80 and the Homebrew verifier handoff repair from #81. Preserve every released section and credit @Amitdvl. Commander and referenced GitHub Actions are current. No version bump, tag, or publication is included.
add --helpandedit --helpnow explain that--alarmschedules a notification without enabling the native Urgent toggle, and direct users to Reminders.app to enable Urgent. Command documentation carries the same guidance. EventKit alarm behavior is unchanged.Fixes #79 through the reporter's explicitly requested documentation fallback. The public EventKit SDK exposes notification alarms but no native Urgent property. Thanks @Amitdvl for reporting the missing CLI guidance; release-note credit is in #82, which lands last.
Validation:
make check(92 tests, 93.8% core coverage), release build, actualadd --helpandedit --helpoutput, docs build, and P2 branch autoreview all passed. CI: https://github.com/openclaw/remindctl/actions/runs/34104839155.