revert: bound serialized writer contention#728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert #727 in full and restore the exact publication controller and state-lease timeout from immediately before that merge.
Why this rollback
#727 deliberately clamped state-contention publication to four workers. The control activated as designed, but the immediate production samples moved in the wrong direction for the incident:
498 -> 518 -> 531 -> 536 -> 539-12/hourpublished 20/hour + superseded 4/hourversus arrivals of52/hourThe first fully constrained cohort did produce one successful
publication_appliedresult, so this rollback is an operator-directed emergency decision rather than proof that every #727 mechanism was incorrect.Scope
74ccb2ecab50916f7a4372b823dac25d1c7d11f36444e678dccb3cce1505827674b05a1f2f7ce397Validation
The Windows checkout formatter reported the established line-ending noise on the four reverted files. The staged tree was independently verified to equal the already-green pre-#727 tree exactly.
At the maintainer's explicit emergency direction, the normal additional Codex-review and Crabbox rerun gates were waived for this exact rollback. The focused tests above had already completed successfully.
Rollback risk
This restores the pre-#727 behavior:
Post-merge monitoring must compare successful
published + supersededdelivery with arrivals and must not mistake dead-letter disposal for recovery.Attribution
This reverts the narrow CSW-049 follow-up authored in #727. It leaves the earlier state-safety work and contributor attribution in #722, #723, and #724 intact.
No automerge is requested.