Skip to content

revert: bound serialized writer contention#728

Merged
brokemac79 merged 1 commit into
mainfrom
codex/csw-049-revert-727
Jul 20, 2026
Merged

revert: bound serialized writer contention#728
brokemac79 merged 1 commit into
mainfrom
codex/csw-049-revert-727

Conversation

@brokemac79

Copy link
Copy Markdown
Contributor

Summary

Revert #727 in full and restore the exact publication controller and state-lease timeout from immediately before that merge.

Why this rollback

#727 deliberately clamped state-contention publication to four workers. The control activated as designed, but the immediate production samples moved in the wrong direction for the incident:

  • pending: 498 -> 518 -> 531 -> 536 -> 539
  • latest 15-minute net drain: -12/hour
  • latest useful delivery: published 20/hour + superseded 4/hour versus arrivals of 52/hour

The first fully constrained cohort did produce one successful publication_applied result, so this rollback is an operator-directed emergency decision rather than proof that every #727 mechanism was incorrect.

Scope

Validation

pnpm run build:repair
pnpm run build:dashboard
node --test test/dashboard-worker.test.ts
  156 passed, 0 failed
node --test --test-name-pattern "state publish lease" test/repair/git-publish.test.ts
  5 passed, 0 failed
pnpm run lint:repair
pnpm run lint:dashboard
pnpm run lint:scripts
git diff --cached --check
git write-tree == 6444e678dccb3cce1505827674b05a1f2f7ce397^{tree}

The Windows checkout formatter reported the established line-ending noise on the four reverted files. The staged tree was independently verified to equal the already-green pre-#727 tree exactly.

At the maintainer's explicit emergency direction, the normal additional Codex-review and Crabbox rerun gates were waived for this exact rollback. The focused tests above had already completed successfully.

Rollback risk

This restores the pre-#727 behavior:

  • adaptive publication can again admit 24–48 publishers;
  • state-lease acquisition returns to 180 seconds;
  • the prior high-contention retry/dead-letter storm may return while all publishers serialize behind the one state writer.

Post-merge monitoring must compare successful published + superseded delivery with arrivals and must not mistake dead-letter disposal for recovery.

Attribution

This reverts the narrow CSW-049 follow-up authored in #727. It leaves the earlier state-safety work and contributor attribution in #722, #723, and #724 intact.

No automerge is requested.

Reverts 74ccb2e (#727). Restores the pre-#727 publication capacity controller and state-lease acquisition timeout.
@brokemac79
brokemac79 merged commit 7f8ca7e into main Jul 20, 2026
8 checks passed
@brokemac79
brokemac79 deleted the codex/csw-049-revert-727 branch July 20, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant