Skip to content

fix: run exact publishers on current main#616

Merged
brokemac79 merged 1 commit into
mainfrom
codex/disable-exact-publish-ledger
Jul 16, 2026
Merged

fix: run exact publishers on current main#616
brokemac79 merged 1 commit into
mainfrom
codex/disable-exact-publish-ledger

Conversation

@brokemac79

Copy link
Copy Markdown
Contributor

Summary

Repairs queued exact-review publication without reducing the queue's existing
parallel publisher capacity.

  • Validate the immutable artifact against its producer SHA, but run the
    publisher from current main so repaired publication logic is used.
  • Recognize legacy artifacts with no durable review-lease tuple and safely
    enqueue one fresh exact review instead of attempting a stale target mutation.
  • Remove the exact publisher's second action-ledger state publication, which
    amplified shared clawsweeper-state contention after the actual review
    publication had already completed.

Incident evidence

This is deliberately not a claim that #592 was the original incident cause.

Related: #592, #593, #610, #611, #612, #614.

Implementation and safety

The artifact validator still binds the producer SHA and target identity. Only
the implementation checkout changes to main. Legacy tuple-less artifacts do
not receive state/target publication credentials and do not mutate their target;
they dispatch one signed fresh exact review using the existing source-drift
route. Normal exact publication keeps its existing 24-slot capacity and broad
publication stays target-scoped.

This is an immediate repair for historical artifact execution and avoidable
state-write pressure. It does not claim to fully solve the older shared-state
race demonstrated by #107787. A separate bounded state-write critical-section
repair remains warranted.

Validation

pnpm run build:all
pnpm exec node --test --test-name-pattern 'exact event review hands immutable artifacts|publish workflow dispatches immediate apply|trusted comment router owns command ledger capacity retries|every action-ledger publication authenticates' test/sweep-workflow.test.ts test/clawsweeper-action-ledger.test.ts test/repair/command-ops-action-ledger.test.ts
pnpm exec node -e "const fs=require('node:fs'); const YAML=require('yaml'); YAML.parse(fs.readFileSync('.github/workflows/sweep.yml','utf8')); console.log('sweep.yml parsed')"
git diff --check
codex review --uncommitted
git fetch origin main --prune
codex review --base origin/main

Focused proof: 6 passing tests; TypeScript build and workflow YAML parse pass.
Both Codex review passes were clean. actionlint is not installed on this host.
The full workflow suite has five established native-Windows baseline failures
because WSL cannot execute /bin/bash; the touched tests pass and a Linux
Crabbox build completed.

Risk and rollout

This touches a GitHub Actions workflow, so GitHub App/OAuth workflow scope is
the deployment risk. Roll out by observing the next legacy and current exact
publisher runs: legacy artifacts should complete by requeueing once, while
normal artifacts should publish/routably defer without the extra ledger commit.
No bulk backlog replay is included.

@brokemac79
brokemac79 requested a review from a team as a code owner July 16, 2026 01:37
@brokemac79

Copy link
Copy Markdown
Contributor Author

@clawsweeper review

@clawsweeper

clawsweeper Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant