feat(dashboard): OpenClaw Bay improvements#597
Conversation
|
@clawsweeper review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
@clawsweeper review |
51febf9 to
6ff6d10
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
@clawsweeper review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
a6f9e16 to
e07f5c3
Compare
|
Codex review: needs maintainer review before merge. Reviewed July 17, 2026, 2:45 PM ET / 18:45 UTC. Summary Reproducibility: not applicable. This PR adds an experimental observability capability rather than repairing a reported broken contract. The supplied final-head live output provides a concrete verification path for the new dashboard behavior. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Merge only the bounded, read-only Bay restoration after a maintainer confirms the experimental dashboard scope, preserving aggregate queue totals as authoritative and treating the worker sample as explicitly incomplete context. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR adds an experimental observability capability rather than repairing a reported broken contract. The supplied final-head live output provides a concrete verification path for the new dashboard behavior. Is this the best way to solve the issue? Yes. Reusing the existing cache-backed AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 556107bfd1a9. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (4 earlier review cycles)
|
* feat(dashboard): expose exact-review pressure telemetry Co-authored-by: brokemac79 <255583030+brokemac79@users.noreply.github.com> * docs(dashboard): describe exact-review pressure telemetry Co-authored-by: brokemac79 <255583030+brokemac79@users.noreply.github.com> * feat(dashboard): render exact-review pressure Co-authored-by: brokemac79 <255583030+brokemac79@users.noreply.github.com> * chore: remove unreleased changelog entry --------- Co-authored-by: brokemac79 <255583030+brokemac79@users.noreply.github.com> Co-authored-by: brokemac79 <martin_cleary@yahoo.co.uk> (cherry picked from commit 41ea43b)
(cherry picked from commit a4c5cc0)
e07f5c3 to
fcbd951
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Related: #555, #567, #569, #586, #621
What Problem This Solves
Restores the compact exact-review queue context that OpenClaw Bay lost in the broad #586 rollback. Operators viewing the experimental Bay route could still see individual crustaceans, but could no longer see whether review admission, result publication, or handoff pressure was building, draining, or stalled.
Why This Change Was Made
The Bay now presents the same bounded, cache-backed exact-review concepts as the overview in a deliberately smaller operational format: Review admission, Result publication, and Queue handoff. It preserves the main beach story - Arriving -> Setting up -> Reviewing -> Applying -> Completed - while keeping Repair as a side/recovery cove rather than a normal stage.
The UI reads the existing dashboard
/api/statussnapshot and cache-backed/api/health-history?range=6hendpoint. It adds no browser-side GitHub API scan, no direct GitHub API request surface, and no mutations. History retries are throttled to one attempt per browser minute, including after an HTTP failure.User Impact
Bay viewers can see compact waiting/throughput trends and the current handoff split without leaving the visual page. Point values remain available on the charts, failed history collection is rendered as a visible gap rather than a false zero, and the display remains explicitly read-only.
Evidence
Final-head live browser proof
Tested at
2026-07-17 19:39 BSTon final headfcbd951e6af0670ea310d926d7d8179a46a6d718:The local page rendered the restored control board against the public dashboard's cache-backed status/history feed. The page surfaced its fallback explicitly because no local GitHub credentials were available:
The rendered page showed both compact six-hour waiting and net-rate charts with point values available to hover, plus the queue-handoff card. Those values are live cache observations and can change between refreshes; the point of this proof is that the final-head Bay UI renders the restored real panel and history, rather than a fixture-only panel.
Focused validation
Result: lint and dashboard type-check passed; 137/137 dashboard-worker tests passed.
Deterministic browser proof used the real local
/bay-demopage in a Docker-backed Playwright container with synthetic, redacted dashboard endpoint responses:Result: 36 assertions, 19 evidence frames, 0 direct GitHub API requests, and 0 mutating requests. The deterministic proof covers compact cards, hoverable point values, bounded sampling, responsive layout, queue-count reconciliation, failed-fetch throttling, failed-collection chart gaps, and pending-only history compatibility.
Review closeout
codex review --uncommitted: clean after fixing two accepted telemetry-history findings (gap boundaries and pending-only compatibility).codex review --base origin/main: clean; no actionable correctness issues.pnpm run review -- --local-range --target-repo openclaw/clawsweeper --base origin/main: local-only ClawSweeper review completed with no blocking correctness or security finding. It correctly labels the browser fixture as synthetic; no GitHub comment, label, workflow dispatch, or other mutation was made.Risks and Rollout
Maintainer Direction
The current OpenClaw maintainer task owner explicitly requested this narrow restoration after #586 and requested final-head live proof before it is considered for merge. The intended product direction is therefore limited to this experimental, read-only Bay observability surface; it does not reinstate queue control, scheduling, workflow, or mutation behaviour.
Attribution
This restores bounded observability from #555 and #569 after #586. #569 carried the Bay pressure work from #567; original provenance is retained through the cherry-picks. The current queue semantics from #621 remain authoritative.
No changelog change is included.