Repository navigation
fix(cli): forward checker controls through --check - #159
Closed
vincentkoc wants to merge 3 commits into
Closed
vincentkoc wants to merge 3 commits into
vincentkoc wants to merge 3 commits into
Conversation
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bun --check --threads 2currently treats2as the entrypoint, while--threads=2is silently skipped. The runtime parser does not own checker controls, so standalone checks, run/test checks, and CLI builds lose the requested settings.Parse checker controls only when
--checkbelongs to Bun, then carry the parsed settings into the checker. Resolve command names from parsed positionals so a project path namedbuildorrunstays a value. Keep ordinary script arguments,--boundaries,-p, Node aliases, Bunx, and package scripts unchanged. CLI builds forward threads and project selection;Bun.build()retains its independent defaults.The shared option state, conditional parse tables, and execArgv handling account for the Rust change (+248 net lines). Regression coverage adds eight focused cases for spaced/equal controls, validation, formatting, successful execution, and sibling argument ownership. The workspace-filter test also covers scripts named
build,test, andrun, before and after successful checking. Documentation names the supported invocation forms.Validation:
33aa8d4a46ed24914d41c9772f2602f600e2df12against upstream canary1.4.4-canary.1+11b450ca9: 3 pass / 6 fail. The five forwarding cases and workspace routing fail; ordinary runtime, Node, and Bunx preservation cases pass.git diff --checkpass. Independent source review covered parser boundaries, option values, pretty precedence, and execArgv replay.67ff797d7b) ran all 16 selected files: 15 passed; the checker file had 632 passes, 4 skips, and 3 failures. This caught a filtered-script dispatch regression and two incorrect new summary/usage assertions, now corrected. Its binary SHA-256 is826dc4e418c2489078577344f591d180ee92684f6de7b69e3298372dc78478a9.059333b3b164c154f743fb034440c082dff18eecbuilt on Linux and macOS in native CI. Linux ran all 16 selected files: 15 passed; the checker file had 633 passes, 4 skips, and 2 failures. macOS ran all 12 selected files: 11 passed; the checker file had 634 passes, 3 skips, and the same 2 failures. Both failures were test expectations: singularfilein the summary and an unsupportedbun test --filterassumption. The earlier-head results remain separate.33aa8d4a46ed24914d41c9772f2602f600e2df12changes only those test expectations. A complete Git diff verifies that production, documentation, and build inputs are identical to059333b3b164c154f743fb034440c082dff18eec.33aa8d4pass against the verified macOS ARM64 release artifact built from059333b3b: 9 pass / 0 fail, 16 assertions, exit 0. Command:<verified-binary> test test/cli/check/check.test.ts -t 'checker controls|--check with --filter, --parallel or --sequential'. This includes the six successful workspace-script routes. The binary reports revision1.4.4-canary.1+059333b3band embedded TypeScript7.0.2.4ea7d5abbe3fa3670beec94b6a0772e9af104f5dd1f6735f080737d469af8bfe; binary SHA-2566efa2acf838549e137fe752446e3f340f178f6b07c45ab27d5bca2343ab44fa4. Its commit manifest matches full binary source059333b3b164c154f743fb034440c082dff18eec.Full native cross-platform CI at current head
33aa8d4has not run and remains a landing gate. The focused result above qualifies the corrected test surface; it does not claim a full current-head CI pass. This PR remains a draft.This draft targets a separate CI-only baseline built on upstream
11b450ca9b575b03f95bde209ff4f037fa14b374. The baseline carries the fork's maintained native workflow, adds an optional dispatch comparison base, and rejects truncated Git inventory output. Those carrier files are outside this PR's diff. There are no TypeScript semantic changes or incremental-cache changes here.