Skip to content

fix(test): preserve unlimited test children and check cache progress - #133

Merged
steipete merged 4 commits into
mainfrom
claude/compile-cache-progress-watchdog
Oct 6, 2026
Merged

steipete merged 4 commits into
mainfrom
claude/compile-cache-progress-watchdog

Conversation

@steipete

@steipete steipete commented Oct 6, 2026 •

Copy link
Copy Markdown

The test runner can kill an unlimited test’s live child when a completed test’s stale deadline fires. Its process-reaping check treats the no-deadline/EPOCH timestamp as expired. Exclude that sentinel, matching the existing entry timeout check, and cover the completed-deadline/live-child sequence with a deterministic regression.

The deferred compile-cache idle test now preserves its ten-second persistence-progress guard and bounds module loading, pipe flushes, child exit, and cleanup individually. The complete 2,000-module workload, late-module handshake, 2,002-file assertion, idle-generation window, and signal-exit budget remain unchanged.

The exact Windows binary from run 37386790583 reproduces the old 30-second aggregate timeout 3/3 under a controlled CPU quota while files keep appearing. An independent driver completes all 2,002 entries in 64.7 seconds; the proposed test passes under that quota in 52.6/52.2 seconds. Deliberately stalled persistence, startup, and exit still fail at their ten-second guards. That hosted failure retained no progress timeline, so its specific runner-level trigger remains unknown. This is distinct from #53’s Linux idle-accounting fix and #130’s Windows execute-access scan fix.

The child-lifetime regression fails 3/3 on old Mac and Windows x64 fork binaries and official upstream Bun 13a98b0d. Exact-source Windows pairs fail 3/3 before and pass 3/3 with the owner fix. Two stale hook-error column expectations were corrected from 15 to 11 after the pre-change fork reproduced all five failures and Node 24 confirmed column 11; exact source-position and error-attribution checks remain intact.

Final validation applies to 29cbbbf595 on main 10b749212a:

  • P2 Codex autoreview and the final pre-merge review are scoped-clean.
  • Local release build passes, with 25 test-runner tests and 214 module tests passing; all 12 Rust targets pass.
  • Native CI: Linux 16/16 and Darwin 13/13, first attempt. Its merge tree exactly matches the reviewed candidate.
  • Windows CI: x64 and ARM64 each 31/31, both native smoke jobs and manifest pass on the first attempt. The immutable workflow is separate from runtime source; native revisions, WebKit identity, archive/executable/profile hashes, and PE architectures are verified for this exact source commit.
  • OpenClaw consumer tests pass 7 + 22 before and after this exact commit, with the before binary’s tree matching current main and isolated HOME/state/configuration/temp directories.

Format, JavaScript/source lint, Clippy, Miri, and lol-html tests pass. Mordant reports the existing bare_bool_args finding in src/resolver/package_json.rs; its source, baseline, configuration, toolchain, and explicitly advisory workflow setting are unchanged from main. The initial issue-finder run lacked authentication; no credentials or CI settings were changed.

The shared owner fix is also proposed in oven-sh#44613 with a passing upstream-specific build and full test-runner suite. The separate Windows rename fix remains in oven-sh#44601.

@steipete
steipete marked this pull request as ready for review October 6, 2026 02:30
@steipete
steipete merged commit 221126e into main Oct 6, 2026
10 of 11 checks passed
@steipete
steipete deleted the claude/compile-cache-progress-watchdog branch October 6, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant