Skip to content

feat(exec): add component exec terminal with WebSocket proxy#634

Draft
Ketharan wants to merge 6 commits into
openchoreo:mainfrom
Ketharan:main
Draft

feat(exec): add component exec terminal with WebSocket proxy#634
Ketharan wants to merge 6 commits into
openchoreo:mainfrom
Ketharan:main

Conversation

@Ketharan

@Ketharan Ketharan commented Jun 15, 2026

Copy link
Copy Markdown

Summary

  • Adds a Terminal tab to the component detail page embedding an xterm.js shell that connects via WebSocket to the OpenChoreo exec endpoint
  • Implements a two-step auth flow: POST /exec/init (HTTP, token stored server-side) → WS /exec/ws?sessionId=<uuid> (no custom headers needed from browser)
  • Gates access behind a new openchoreo.exec permission with per-environment ABAC support via useExecPermission

Test plan

  • Navigate to a deployed component → Terminal tab is visible
  • Click Connect → shell opens and accepts keyboard input
  • Resize browser window → terminal reflows and PTY dimensions update on the server
  • Click Disconnect → session ends cleanly; Connect starts a fresh session
  • User without component:exec permission sees Forbidden state
  • User with permission denied for a specific environment sees per-environment error message
  • Component with no active release bindings shows "No active deployments" message

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 350487c1-425a-43a5-a779-2b1d85d66566

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Changeset detected — the following file(s) will be released with this PR:

.changeset/component-exec-terminal.md

@Ketharan Ketharan force-pushed the main branch 2 times, most recently from da16157 to 618b081 Compare June 16, 2026 08:52
Signed-off-by: Ketharan <ketharan.mail@gmail.com>
Ketharan added 5 commits June 16, 2026 16:06
Signed-off-by: Ketharan <ketharan.mail@gmail.com>
Signed-off-by: Ketharan <ketharan.mail@gmail.com>
Signed-off-by: Ketharan <ketharan.mail@gmail.com>
Signed-off-by: Ketharan <ketharan.mail@gmail.com>
Signed-off-by: Ketharan <ketharan.mail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant