Add recording_arrays relationship to Simulation - #689
Open
eleftherioszisis wants to merge 1 commit into
Open
Conversation
Relates a Simulation to the SimulatableExtracellularRecordingArray(s) it records with via a many-to-many junction table, enabling entitysdk to stage the electrode_array_weight_matrix assets appropriately. Closes #680
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
james-isbister
left a comment
james-isbister
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but I'll let @GianlucaFicarelli review the details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recording_arraysrelationship onSimulationlinking toSimulatableExtracellularRecordingArrayvia a new junction table.entitysdk.stage_simulationto discover and stageelectrode_array_weight_matrixassets.Closes #680
Test plan
test_create_oneverifies emptyrecording_arraysby defaulttest_create_one_with_recording_arraysverifies association with 2 arrays