Support native list params in filters#273
Merged
Merged
Conversation
eleftherioszisis
changed the title
eleftherioszisis
marked this pull request as ready for review
July 3, 2025 18:31
GianlucaFicarelli
left a comment
GianlucaFicarelli
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, it's for sure clearer than using the comma separated lists.
Just a reminder that it's a breaking change so the deployment should be coordinated with the other clients and services, and it would be better not to merge this week.
eleftherioszisis
force-pushed
the
fix-query-commas
branch
from
July 7, 2025 08:32
6b926a5 to
8ee649f
Compare
eleftherioszisis
force-pushed
the
fix-query-commas
branch
from
July 7, 2025 11:39
2f41923 to
a4914ea
Compare
GianlucaFicarelli
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support native param lists instead of comma separated strings.
Thanks to arthurio/fastapi-filter#620
Fixes https://github.com/openbraininstitute/prod-explore-functionality/issues/191