Repository navigation
fix(famafrench): Australia's country portfolio file is Austrlia.Dat - #7758
Merged
dlee-bq merged 4 commits intoOct 17, 2026
Merged
Conversation
The members of F-F_International_Countries.zip (and its _Wout_Div twin) use eight-character names, and Australia's is Austrlia.Dat, not Australia.Dat. Every Australia request failed with "not found in available indexes". The other twenty countries already map to their member names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
artcashin
force-pushed
the
fix/famafrench-australia-file
branch
from
October 9, 2026 23:25
f7df957 to
e8e0f3a
Compare
dlee-bq
enabled auto-merge
October 17, 2026 23:07
deeleeramone
approved these changes
Oct 17, 2026
deeleeramone
left a comment
deeleeramone
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Fama-French international country portfolios fail for Australia with
ValueError: Index Australia.Dat not found in available indexes. Members ofF-F_International_Countries.zip(and ofF-F_International_Countries_Wout_Div.zip) use eight-character names, likeNethrlnd.DatandSwtzrlnd.Dat, and Australia's isAustrlia.Dat. The other twenty countries were already mapped correctly.Change
COUNTRY_PORTFOLIO_FILES["Australia"] = "Austrlia.Dat".Tests
Two new tests in
tests/test_helpers.py:test_every_country_maps_to_a_zip_memberchecks every mapped name against the archive's 21 members, as listed on 2026-10-09.test_get_international_portfolio_data_australiareads Australia from a stub archive.Both fail without the change and pass with it. The provider suite passes: 130 tests (Python 3.12).
Results from a deployment
We run this as an overlay on the 2.0.0 wheel in OpenBQ's Docker image. Before the change, a sweep of every widget gave the
Austrlia.Datmismatch for Australia. With it, the Australia country portfolio returns 612 rows.Not included
Nothing else.
🤖 Generated with Claude Code