ci: pass the Rust toolchain explicitly to dtolnay/rust-toolchain - #7
Merged
Merged
Conversation
The pinned commits come from the action's version branches, whose toolchain input defaults to that version. Dependabot can move such a pin to a master commit, where the input is required, and every Rust job would then fail (it happened in axiolid/kernel#178). Passing the version the pin already names keeps the toolchain fixed whichever commit the action is pinned to. Claude-Session: https://claude.ai/code/session_01V2HyuKe7QWf4WKxHdEJEjD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolchain:input to the 1dtolnay/rust-toolchainstep(s) that relied on the action's version-branch default, using the version the pin comment already names.master, wheretoolchainis required, so every Rust job would fail. That happened in ci: bump the github-actions group across 1 directory with 9 updates axiolid/kernel#178 and was caught in review. With the input set, the toolchain stays fixed whichever commit the action is pinned to.with:inputs are untouched (checked by parsing every edited workflow before and after).