fix(openapi-fetch): prevent body parsing for HEAD requests regardless of Content-Length#2205
Merged
drwpow merged 2 commits intoopenapi-ts:mainfrom Mar 18, 2025
Merged
Conversation
… of Content-Length
❌ Deploy Preview for openapi-ts failed.
|
🦋 Changeset detectedLatest commit: dabe0b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
drwpow
reviewed
Mar 17, 2025
Contributor
drwpow
left a comment
drwpow
left a comment
There was a problem hiding this comment.
This looks good to me. Just add a patch changeset (see GitHub comment) so we can create a release from this PR
| expect(method).toBe("HEAD"); | ||
| }); | ||
|
|
||
| test("handles HEAD requests with non-zero Content-Length without parsing the body", async () => { |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes how HEAD method requests are handled in openapi-fetch by preventing body parsing regardless of the Content-Length header value.
According to RFC 9110, HEAD responses should have the same metadata as GET but must not include a body.
Previously, the library only handled this correctly when Content-Length was "0", causing JSON parsing errors in other cases.
Fixes HEAD method with non-zero Content-Length triggers JSON parsing error #2195.
How to Review
Checklist
docs/updated (if necessary) - N/Apnpm run update:examplesrun (only applicable for openapi-typescript) - N/A