Skip to content

[Store] Remove unreachable INVALID_BATCH_ID check after freeBatchID #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stmatengss wants to merge 1 commit into
base: hemist/cxl-level-store
Choose a base branch
from
Open

[Store] Remove unreachable INVALID_BATCH_ID check after freeBatchID #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions mooncake-store/src/transfer_task.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,11 +637,6 @@ std::optional<TransferFuture> TransferSubmitter::submitTransfer(
return std::nullopt;
}

if (batch_id == INVALID_BATCH_ID) { // INVALID_BATCH_ID
LOG(ERROR) << "Invalid batch ID for transfer engine operation";
return std::nullopt;
}

// Create state with transfer engine context - no polling thread
// needed
auto state = std::make_shared<TransferEngineOperationState>(
Expand All @@ -666,20 +661,11 @@ std::optional<TransferFuture> TransferSubmitter::mp_submitTransfer(
if (!s.ok()) {
LOG(ERROR) << "Failed to submit all transfers, error code is "
<< s.code();
// Note: batch_id will be freed by TransferEngineOperationState
// destructor if we create the state object, otherwise we need to free
// it here
engine_.freeBatchID(batch_id);
return std::nullopt;
}

if (batch_id == INVALID_BATCH_ID) { // INVALID_BATCH_ID
LOG(ERROR) << "Invalid batch ID for transfer engine operation";
return std::nullopt;
}

// Create state with transfer engine context - no polling thread
// needed
// Create state with transfer engine context - no polling thread needed
auto state = std::make_shared<TransferEngineOperationState>(
engine_, batch_id, batch_size);

Expand Down