Add date warning - #3806
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 571f10ac29
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ] | ||
| sdist = { url = "https://files.pythonhosted.org/packages/96/f0/5eb65b2bb0d09ac6776f2eb54adee6abe8228ea05b20a5ad0e4945de8aac/anyio-4.12.1.tar.gz", hash = "sha256:41cfcc3a4c85d3f05c932da7c26d0201ac36f72abd4435ba90d0464a3ffed703", size = 228685, upload-time = "2026-01-06T11:45:21.246Z" } | ||
| sdist = { url = "https://files.pythonhosted.org/packages/a9/d2/f4d173e22df740bc37b1db102b386ba719b66e95b0f0d751f556b387e6d2/anyio-4.15.1.tar.gz", hash = "sha256:9f28306018cbd6d329e64a36d58256edff76dd996fe423bc957326e578b82a94", size = 276966, upload-time = "2026-09-05T10:42:39.44Z" } |
There was a problem hiding this comment.
This entry pins AnyIO 4.15.1, uploaded at 2026-09-05T10:42Z only hours before this 2026-09-05 commit, despite pyproject.toml:84 specifying exclude-newer = "8 days"; the lock similarly adds several other packages uploaded only 1–3 days earlier. uv help lock defines this option as limiting candidate packages to those uploaded before the cutoff, while locked syncs consume the already-selected artifacts, so this refresh defeats the repository's dependency cooling control. Regenerate the lock with the required uv configuration or omit the unrelated lock refresh.
AGENTS.md reference: AGENTS.md:L31-L34
Useful? React with 👍 / 👎.
| return json_schema.get("format") in {"date", "date-time"} or any( | ||
| map( | ||
| _is_date_format, | ||
| (json_schema.get("properties") or {}).values(), | ||
| ) |
There was a problem hiding this comment.
For a response model such as class R(BaseModel): when: date | None, Pydantic places the date schema below properties.when.anyOf, but this helper only recurses through properties, $defs, and items, so it returns false and skips the new warning. Dates under Pydantic v1's definitions, dictionary additionalProperties, and tuple prefixItems are missed for the same reason; recurse through all dictionary/list child schemas or explicitly handle these containers.
Useful? React with 👍 / 👎.
| [[package]] | ||
| name = "openai" | ||
| version = "3.8.0" # x-release-please-version | ||
| version = "3.8.0" |
There was a problem hiding this comment.
Removing the # x-release-please-version suffix makes the dependency-locks job fail unconditionally: .github/workflows/ci.yml:63-67 explicitly asserts that the lockfile contains version = "<project version>" # x-release-please-version before running uv lock --check. Preserve this marker when refreshing the lockfile.
Useful? React with 👍 / 👎.
1 participant
Changes being requested
Additional context & links