fix: guard against IndexError/ValueError when bare dict has no type args - #3421
Closed
Vitaliy-Pikalo wants to merge 2 commits into
Closed
fix: guard against IndexError/ValueError when bare dict has no type args#3421Vitaliy-Pikalo wants to merge 2 commits into
Vitaliy-Pikalo wants to merge 2 commits into
Conversation
Contributor
|
Thank you for the contribution. The missing type arguments for bare Closing this PR because the merged change resolves the same crash. Please use a release containing #3760 when available; the fix is not included in v3.11.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two crashes when a TypedDict field or model field uses a bare
dict(no type params).1. IndexError in
_transform_recursive(_utils/_transform.py) — fixes #3338get_args(bare_dict)returns(), so[1]index access crashes.Applied to both sync and async paths.
2. ValueError in
construct_type(_models.py) — fixes #3341_, items_type = get_args(bare_dict)raisesValueError: not enough values to unpack.Both are simple early-return guards with zero behaviour change for
dict[K, V].Fixes
Closes #3338
Closes #3341