fix(parsing): handle None response.output in parse_response to preven… - #3415
Closed
Vitaliy-Pikalo wants to merge 1 commit into
Closed
fix(parsing): handle None response.output in parse_response to preven…#3415Vitaliy-Pikalo wants to merge 1 commit into
Vitaliy-Pikalo wants to merge 1 commit into
Conversation
Contributor
|
Thank you for the contribution! The null-output parsing and stream recovery fix has landed in #3345, so I am closing this PR as superseded. We appreciate your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3325
Changes being requested
parse_responseinsrc/openai/lib/_parsing/_responses.pyiterates directly overresponse.outputwithout guarding againstNone. When the Responses API returns a response withoutput=null(e.g. a content-filtered or empty response), this crashes with:Fix: Replace:
With:
This makes the behavior safe when
response.outputisNone, treating it as an empty list and returning an emptyParsedResponse.Additional context & links
response.outputis null inresponse.completedevent (chatgpt.com Codex backend) #3325src/openai/lib/_parsing/_responses.pyline 61outputis null