Skip to content

fix: handle bare list annotations in construct_type #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paksh1 wants to merge 1 commit into from
+7 −0
Closed

fix: handle bare list annotations in construct_type #3413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/openai/_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,9 @@ def construct_type(*, value: object, type_: object, metadata: Optional[List[Any]
if not is_list(value):
return value

if not args:
return value

inner_type = args[0] # List[inner_type]
return [construct_type(value=entry, type_=inner_type) for entry in value]

Expand Down
4 changes: 4 additions & 0 deletions tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,10 @@ class NestedModel(BaseModel):
assert cast(Any, m.nested) is False


def test_bare_list_type() -> None:
assert construct_type(value=[{"hello": "world"}], type_=list) == [{"hello": "world"}]


def test_raw_dictionary() -> None:
class NestedModel(BaseModel):
nested: Dict[str, str]
Expand Down